-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update slot viz struct to new design #59
Conversation
frontend/types/api/slot_viz.ts
Outdated
proposal?: VDBSlotVizActiveDuty; | ||
slashing?: VDBSlotVizActiveDuty[]; | ||
proposal?: VDBSlotVizTuple; | ||
attestations: VDBSlotVizStatus<VDBSlotVizDuty>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on Discord, please make all 4 properties (proposal, attestations, sync, slashing) optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
for validator := range validatorsArray { | ||
for slot, duty := range dutiesInfo.EpochAttestationDuties[uint32(validator)] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this here was a bug before my changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
No description provided.