Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update slot viz struct to new design #59

Merged
merged 8 commits into from
Mar 5, 2024
Merged

Conversation

LuccaBitfly
Copy link
Contributor

No description provided.

@MauserBitfly MauserBitfly mentioned this pull request Mar 1, 2024
proposal?: VDBSlotVizActiveDuty;
slashing?: VDBSlotVizActiveDuty[];
proposal?: VDBSlotVizTuple;
attestations: VDBSlotVizStatus<VDBSlotVizDuty>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Discord, please make all 4 properties (proposal, attestations, sync, slashing) optional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines -533 to -534
for validator := range validatorsArray {
for slot, duty := range dutiesInfo.EpochAttestationDuties[uint32(validator)] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this here was a bug before my changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@Eisei24 Eisei24 merged commit c68fca8 into main Mar 5, 2024
3 checks passed
@Eisei24 Eisei24 deleted the NOBIDS/slot-viz-update branch March 5, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants